sysdump: Remove the Hidden flag #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been using the sysdump command for a while in both cilium and cilium-cli CI workflows and it's been stable. Signed-off-by: Michi Mutsuzaki <[email protected]>
|
Multicluster tests failed on known issue #361: https://github.com/cilium/cilium-cli/runs/3309372422?check_suite_focus=true This is unrelated to the changes in this PR, so let's merge. |
|
Looks like this PR introduced a Not sure why this wasn't caught on the PR 🤔 |
tklauser
added a commit
that referenced
this pull request
Aug 12, 2021
The change in PR #481 wasn't properly formatted, leading to a golangci-lint failure on master: https://github.com/cilium/cilium-cli/runs/3310670546 Fix it by running `goimports -w internal/cli/cmd/sysdump.go`. Signed-off-by: Tobias Klauser <[email protected]>
Fix for the formatting issue here: #483 Still not sure why it wasn't caught on the PR, probably something with the |
tklauser
added a commit
that referenced
this pull request
Aug 13, 2021
The change in PR #481 wasn't properly formatted, leading to a golangci-lint failure on master: https://github.com/cilium/cilium-cli/runs/3310670546 Fix it by running `goimports -w internal/cli/cmd/sysdump.go`. Signed-off-by: Tobias Klauser <[email protected]>
aditighag
pushed a commit
to aditighag/cilium-cli
that referenced
this pull request
Apr 21, 2023
The change in PR cilium#481 wasn't properly formatted, leading to a golangci-lint failure on master: https://github.com/cilium/cilium-cli/runs/3310670546 Fix it by running `goimports -w internal/cli/cmd/sysdump.go`. Signed-off-by: Tobias Klauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using the sysdump command for a while in both cilium and
cilium-cli CI workflows and it's been stable.
Signed-off-by: Michi Mutsuzaki [email protected]