internal/cli/cmd: fix formatting linter issue #483
Conversation
The change in PR #481 wasn't properly formatted, leading to a golangci-lint failure on master: https://github.com/cilium/cilium-cli/runs/3310670546 Fix it by running `goimports -w internal/cli/cmd/sysdump.go`. Signed-off-by: Tobias Klauser <[email protected]>
It seems this option doesn't work as intended. Since we currently do not have any static checks failing on master, it should be safe to disable the option. Signed-off-by: Tobias Klauser <[email protected]>
|
not sure why the workflow is not starting. will re-push |
|
Commit 7b66ebe does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
michi-covalent
force-pushed
the
pr/tklauser/sysdump-fix-linter-issue
branch
from
7b66ebe
to
b242047
Compare
|
Commit 7b66ebe does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
AKS job failed on #367: https://github.com/cilium/cilium-cli/pull/483/checks?check_run_id=3314687814 Both are known flakes and this PR only affects code formatting and CI. And it fixes failing static checks on current |
The change in PR #481 wasn't properly formatted, leading to a
golangci-lint failure on master:
https://github.com/cilium/cilium-cli/runs/3310670546
Fix it by running
goimports -w internal/cli/cmd/sysdump.go.Also fix the
golangci-lintGH action configuration to disable theonly-new-issueswhich seems to lead to static checker failures correctly failing tests on PRs. See #484 for an example run.