Switch Lineage from cisagov/skeleton-generic to cisagov/skeleton-docker
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent/merge_in_upstream_changes
Merge in upstream changes from cisagov/skeleton-generic
…ent/pull_in_upstream_changes
Pull in upstream changes
Improvement/lgtm
Add skeleton generic updates
…ent/upstream_changes_from_skeleton_generic
…skeleton_generic Upstream changes from cisagov/skeleton-generic
Add test to check for container readiness.
…_versions Update GitHub Action versions for this project
Co-authored-by: Nick <[email protected]>
Update code to use the "docker compose" syntax vice "docker-compose"
These provide samples for the `aws_config` and `scraper.json` files that this Docker image would expect.
Enable the new ignore directives for dependencies managed by cisagov/skeleton-docker.
Update the pytest configuration to reflect this image's configuration.
This reflects the intersection of platforms supported by the base Docker image we are using for our image and the Python packages that will be installed for image functionality.
mcdonnnj
added
improvement
dav3r
reviewed
Jun 30, 2022
Replace the value used for the GitHub token in the LLNL/scraper sample configuration to be more obviously a placeholder. This value still follows the format of GitHub Personal Access Tokens while being obviously a placeholder. Co-authored-by: dav3r <[email protected]>
8 tasks
jsf9k
reviewed
Jul 5, 2022
There was a problem hiding this comment.
Do these changes break anything here?
I took a look at cisagov/ansible-role-code-gov-update, and I think that Ansible role is OK.
Yes this has breaking changes for how it is deployed. I plan on creating a PR to adjust the Ansible role once the improvement/modernize_project branch (what this PR is merging into) is in a final state and before that branch is merged into |
jsf9k
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request changes this project to be based on the cisagov/skeleton-docker project instead of cisagov/skeleton-generic.
💭 Motivation and context
Since this is a Docker project it should be based on the appropriate skeleton. Additionally this change will allow us to correctly update the image configuration and generate a new versioned image for use in deployments.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
to reflect the changes in this PR.