-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Lineage from cisagov/skeleton-generic
to cisagov/skeleton-docker
#30
Switch Lineage from cisagov/skeleton-generic
to cisagov/skeleton-docker
#30
Conversation
…ent/merge_in_upstream_changes
Merge in upstream changes from cisagov/skeleton-generic
…ent/pull_in_upstream_changes
Pull in upstream changes
Improvement/lgtm
Add skeleton generic updates
…ent/upstream_changes_from_skeleton_generic
…skeleton_generic Upstream changes from cisagov/skeleton-generic
Add test to check for container readiness.
…_versions Update GitHub Action versions for this project
Co-authored-by: Nick <[email protected]>
Update code to use the "docker compose" syntax vice "docker-compose"
These provide samples for the `aws_config` and `scraper.json` files that this Docker image would expect.
Enable the new ignore directives for dependencies managed by cisagov/skeleton-docker.
Update the pytest configuration to reflect this image's configuration.
This reflects the intersection of platforms supported by the base Docker image we are using for our image and the Python packages that will be installed for image functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got some questions before I approve...
Replace the value used for the GitHub token in the LLNL/scraper sample configuration to be more obviously a placeholder. This value still follows the format of GitHub Personal Access Tokens while being obviously a placeholder. Co-authored-by: dav3r <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! 🌷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these changes break anything here?
I took a look at cisagov/ansible-role-code-gov-update, and I think that Ansible role is OK.
Yes this has breaking changes for how it is deployed. I plan on creating a PR to adjust the Ansible role once the improvement/modernize_project branch (what this PR is merging into) is in a final state and before that branch is merged into |
🗣 Description
This pull request changes this project to be based on the cisagov/skeleton-docker project instead of cisagov/skeleton-generic.
💭 Motivation and context
Since this is a Docker project it should be based on the appropriate skeleton. Additionally this change will allow us to correctly update the image configuration and generate a new versioned image for use in deployments.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist
to reflect the changes in this PR.