Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in upstream updates #6

Merged
merged 121 commits into from
Oct 7, 2020
Merged

Pull in upstream updates #6

merged 121 commits into from
Oct 7, 2020

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 6, 2020

🗣 Description

This pull request pulls in upstream changes from cisagov/skeleton-generic.

💭 Motivation and Context

I plan to make some changes to the code-gov-update deployment related to cisagov/cyhy_amis#279, so it makes sense to go ahead and update all the related repositories.

🧪 Testing

All pre-commit hooks pass.

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

felddy and others added 30 commits May 3, 2019 16:49
Also update the URL for black since it moved GitHub orgs from ambv to
python.
…ss_yamllint

Make .bandit.yml pass yamllint
This should speed up TravisCI builds.
Add changes from running pre-commit autoupdate
terraform-docs is currently broken with respect to terraform 0.12.
JSON files are already being linted by the pretty-format-json hook.
…re_json_files

Configure prettier to ignore JSON files
Update two text blocks to use the console tag instead of the bash tag…
This config file turns off the "line too long" rule when within a code
block or a table.  Often there is no way to avoid going over 80 lines
in such cases.
The license text is not actually in Markdown, and adding the .md
extension actually makes it render a little differently than intended.
…t_autoupdate

Add updates from running pre-commit autoupdate
…t_autoupdate

Add updates from running pre-commit autoupdate
felddy and others added 17 commits June 22, 2020 17:13
setup-env: A tool to automate a development environment setup.
Notable version changes:
- docker-pre-commit v2.0.0
  This release includes the addition of two new hooks: hadolint and
  hadolint-system. These allow for linting Dockerfiles with the hadolint
  Docker image or a system installation of hadolint respectively.
- isort 5.0.7
  This release takes us from isort 4 to isort 5. There are a multitude of
  changes with information available on the isort 5 release page at
  https://timothycrosley.github.io/isort/docs/major_releases/introducing_isort_5/
  The most notable feature for us is the addition of built-in profiles for
  isort to run under. These profiles provide settings for conforming to various
  popular styles, and black is one of the profiles.
Autoupdates to pre-commit Hooks for 2020-07
Switch the workflow to use cachev2. This puts us up to
date and allows us to consolidate into one cache item.
Keep it up-to-date even though we are not currently
using features added in v2.
Make the job name the first part of the cache key since
it is the only part that isn't variable.
…nd_cache_actions_to_v2

Update actions/cache and actions/setup-python to v2
Autoupdate pre-commit and Additional Maintenance
@jsf9k jsf9k self-assigned this Oct 6, 2020
@jsf9k jsf9k marked this pull request as ready for review October 6, 2020 21:40
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing another one into the light 🔦 Please see my comment about some documentation that got missed.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsf9k jsf9k merged commit 4b4c770 into develop Oct 7, 2020
@jsf9k jsf9k deleted the improvement/upstream-updates branch October 7, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants