Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Job Entity to Api4 #24747

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Add Job Entity to Api4 #24747

merged 1 commit into from
Oct 17, 2022

Conversation

mattwire
Copy link
Contributor

Overview

Add the Job entity to Api4

Before

Not available

After

Available.

Technical Details

Comments

This will allow us to replace the Scheduled jobs with a nice searchable one based on searchkit

@civibot
Copy link

civibot bot commented Oct 14, 2022

(Standard links)

@civibot civibot bot added the master label Oct 14, 2022
@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Oct 15, 2022
@colemanw
Copy link
Member

This API will probably need building out to add more job-related actions, but I don't see any reason not to go ahead & merge this bare-bones version.

@eileenmcnaughton
Copy link
Contributor

I'm fine with this - but it does rather open the question of whether we should have a bit of a practice for supporting where for these new api versions - I'm thinking at the moment of the processGreeting job

@colemanw colemanw merged commit b6ddf30 into civicrm:master Oct 17, 2022
@mattwire mattwire deleted the jobsearchkit branch October 18, 2022 18:49
@mattwire
Copy link
Contributor Author

@eileenmcnaughton Just thinking out loud it might even make more sense to have a different entity for the "adhoc" jobs? Eg. JobAction. The reason for exposing "Job" at this point is that it allows us to implement the admin interface in searchkit.

@eileenmcnaughton
Copy link
Contributor

yeah I get your point. It was pretty messy in v3

I think I'd still like to have where generally available to that class - @colemanw thoughts?

@mattwire
Copy link
Contributor Author

Ah, you mean where to select which jobs to run? Seems like a good idea.

@eileenmcnaughton
Copy link
Contributor

yeah - tbh several of the api actually do what an update does - ie api v4 empty contact update will process_greetings - but you have to 'trick' it wih a meaningless value update which feels a bit odd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants