Enhancements - not for direct merge #101
Conversation
|
I'm just doing some debugging on an issue - I pulled in your first commit as part of my basic cleanup. I didn't pull in your second commit cos I think that screen needs to be replaced with a search kit & adding to it before doing that would seem to make the conversion harder |
|
@mattwire I've pushed up some changes to the repo (which made this stale) - your settings form change should be redundant with the switch to the generic setting form (although I need to re-check that is working correctly). I've also added the first cut of searches to replace the error pages. Unfortunately I didn't get to thing I went to the extension to debug :-( |
mattwire
force-pushed
the
mjw
branch
4 times, most recently
from
c01c45f
to
a60afef
Compare
mattwire
force-pushed
the
mjw
branch
11 times, most recently
from
9a03f15
to
f7f5c44
Compare
CRM/Civixero/Job/Job.mgd.php
Outdated
| @@ -10,13 +10,14 @@ | |||
| 'update' => 'never', | |||
| 'params' => [ | |||
| 'version' => 3, | |||
| 'name' => 'CiviXero Contact Push Job', | |||
There was a problem hiding this comment.
Changing these names will invalidate existing managed entities (or at least remove the sync between managed entities names with the db names) - with the reconcile potentially removing / recreating them / getting upset about name change - feels like it will be a pain to deal with the fallout for an arguable aestethic improvement
mattwire
force-pushed
the
mjw
branch
6 times, most recently
from
dc4ba30
to
be8700a
Compare
mattwire
force-pushed
the
mjw
branch
2 times, most recently
from
d6f4cef
to
9783c55
Compare
mattwire
force-pushed
the
mjw
branch
2 times, most recently
from
a152b2a
to
ca201fe
Compare
mattwire
force-pushed
the
mjw
branch
4 times, most recently
from
0696aa6
to
3cef1b0
Compare
Later version that in Matt's but gets it in there - seems to only be used for the new TrackingCategory at this stage so light integration
mattwire
force-pushed
the
mjw
branch
5 times, most recently
from
d378588
to
17f99c9
Compare
… TrackingCategoryAddOption and TrackingCategoryDeleteOption
@eileenmcnaughton Putting this here so I don't forget. This adds docs, refactors the authorize page so it's easier/clearer to use and moves the navigation menu to Administer->CiviContribute.
Not yet ready for merge because it requires the API4 job API which I think will only be available in 5.56: