Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport existing typings, CKEditorModule, and CKEditorComponent from the main file. #66

Closed
ma2ciek opened this issue Feb 1, 2019 · 0 comments
Assignees
Milestone

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Feb 1, 2019

For now, to use typings somebody would need to type import { CKEditor5 } from '@ckeditor/ckeditor5-angular/ckeditor. Similarly using the CKEditorComponent.

Both files can be re-exported from the main package though:

// ckeditor.module.ts
@NgModule( {
	// ...
} )
export class CKEditorModule {}

export * from './ckeditor';
export { CKEditorComponent } from './ckeditor.component';
@ma2ciek ma2ciek added this to the iteration 22 milestone Feb 1, 2019
@ma2ciek ma2ciek self-assigned this Feb 1, 2019
@ma2ciek ma2ciek changed the title Reexport existing typings and CKEditorComponent from the main file. Reexport existing typings, CKEditorModule and CKEditorComponent from the main file. Feb 5, 2019
@ma2ciek ma2ciek changed the title Reexport existing typings, CKEditorModule and CKEditorComponent from the main file. Reexport existing typings, CKEditorModule, and CKEditorComponent from the main file. Feb 5, 2019
@pomek pomek closed this as completed in #67 Feb 12, 2019
pomek added a commit that referenced this issue Feb 12, 2019
Feature: Reexported `CKEditorModule`, `CKEditorComponent` and typings from the package entry point. Closes #66.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant