Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the default file to the index.ts that reexports module, component and typings #67

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

ma2ciek
Copy link
Contributor

@ma2ciek ma2ciek commented Feb 2, 2019

Suggested merge commit message (convention)

Feature: Reexported CKEditorModule, CKEditorComponent and typings from the package entry point. Closes #66.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for this change.

@ma2ciek
Copy link
Contributor Author

ma2ciek commented Feb 3, 2019

I'll need to mention these changes in our docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 206

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 201: 0.0%
Covered Lines: 121
Relevant Lines: 121

💛 - Coveralls

@pomek
Copy link
Member

pomek commented Feb 12, 2019

I would like to merge this PR with Feature prefix because it introduces new things that could be mentioned in the changelog. Could you rewrite a little the commit message?

@ma2ciek
Copy link
Contributor Author

ma2ciek commented Feb 12, 2019

I would like to merge this PR with Feature prefix because it introduces new things that could be mentioned in the changelog. Could you rewrite a little the commit message?

Fixed.

@pomek pomek merged commit 2a6f55e into master Feb 12, 2019
@pomek pomek deleted the t/66 branch February 12, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants