Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs styling breaks Mathtype equation display #2080

Closed
mlewand opened this issue Sep 18, 2019 · 3 comments · Fixed by #2081
Closed

Docs styling breaks Mathtype equation display #2080

mlewand opened this issue Sep 18, 2019 · 3 comments · Fixed by #2081
Assignees
@mlewand @Mgsy
Labels
package:mathtype type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 33 (v20...

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 18, 2019 •
edited
Loading

Is this a bug report or feature request?

🐞 Bug report

💻 Version of CKEditor

CKEditor v5 @ 12.4.0

📋 Steps to reproduce

Our Mathtype feature guide has CSS that applies display:block (and other goodies) to all images in the content.

Images produced by the Mathtype plugin are inline, but with this CSS they're displaying as blocks.

Somehow we missed it before 🙈

✅ Expected result

image

❎ Actual result

image

image

If you'd like to see this fixed sooner, add 👍 to this post.
@dkonopka dkonopka transferred this issue from ckeditor/ckeditor5-core Oct 2, 2019
@dkonopka dkonopka added this to the iteration 27 milestone Oct 2, 2019
@dkonopka dkonopka added the type:docs This issue reports a task related to documentation (e.g. an idea for a guide). label Oct 2, 2019
@dkonopka dkonopka mentioned this issue Oct 2, 2019
Merged
@mlewand
Copy link
Contributor Author

mlewand commented Oct 3, 2019

Pushing back to next milestone due to #2081 (review)

@mlewand mlewand modified the milestones: iteration 27, next Oct 3, 2019
@mlewand
Copy link
Contributor Author

mlewand commented Apr 6, 2020

We should check whether it's still an issue, as Wiris got a major rewrite recently.

@mlewand mlewand assigned Mgsy and unassigned dkonopka Apr 6, 2020
@mlewand mlewand mentioned this issue Jun 16, 2020
Closed
@mlewand
Copy link
Contributor Author

mlewand commented Jun 16, 2020

The problem is caused by the .formatted p img rule { display: block; margin: 1.5em auto; box-sizing: content-box; } in the https://ckeditor.com/docs/assets/1.3.2/css/styles.css file (source here).

mlewand added a commit that referenced this issue Jun 16, 2020
@mlewand
Docs (ckeditor5): Do not center math equations and chemical formulas. C…
81a9409 
…loses #2080.

Do not center math equations and chemical formulas.
@mlewand mlewand modified the milestones: next, iteration 33 Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

@Mgsy Mgsy

Labels
package:mathtype type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 33 (v20.0.0)
Development

Successfully merging a pull request may close this issue.

[Docs] Do not center math equations and chemical formulas ckeditor/ckeditor5
4 participants
@Reinmar @mlewand @dkonopka @Mgsy