-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Do not center math equations and chemical formulas #2081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that more reliable solution would be to negate image style customization for any editor's editable.
Easiest hax would be to put :not()
in Umberto stylesheet, but it shouldn't know anything about CKE5.
So we need to do it on CKE5 side of things, something like adding: display: initial
for .formatted p img
and proper negation for other customized CSS. But it should apply to all samples, not just MathType alone.
Good catch! Fixed already 🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mgsy Can I ask you to verify whether it doesn't break images in any other samples? What basically happened here is that images in The reason for adding display block was probably to get a nice full width images in our articles content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine 👍
R- for now due to #2080 (comment) |
Rebased the branch onto latest |
Rebased once again onto latest |
@ckeditor/qa-team Gents can I ask you to do some post-merge verification to ensure that images in samples are displayed correctly? I gave it some testing, but would like to have QA see it too. What this PR affects is all the image elements ( Some scenarios that I can see worth testing include:
|
I checked it and didn't find any new bugs, it seems to work fine 👍 |
Suggested merge commit message (convention)
Docs: Do not center math equations and chemical formulas. Closes #2080.
Additional information
http://127.0.0.1:8080/build/docs/ckeditor5/12.4.0/features/math-equations.html