Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Macro benchmarks #248

Merged
merged 1 commit into from
Sep 10, 2015
Merged

fix: Macro benchmarks #248

merged 1 commit into from
Sep 10, 2015

Conversation

WildCryptoFox
Copy link

  • (+) in wrong location in macro definition (Sorry).
  • value_name(s) and possible_value(s), macro implementation repeats over non plural functions
  • --long-option-2 -> --long_option_2 Is this a problem? If so - feel free to use the manual function via long("long-option-2")
  • [positional] expands to value_name("positional") takes_value(true) not index(1)

@WildCryptoFox
Copy link
Author

r? @kbknapp

@WildCryptoFox WildCryptoFox mentioned this pull request Sep 10, 2015
@Vinatorul
Copy link
Contributor

And so tests will be handy 😉

@WildCryptoFox
Copy link
Author

Yepp =D

@WildCryptoFox
Copy link
Author

NOTE: My macro builder is going to need some good docs soon... This is one good sample of just why. It is just a bit too flexible (, and strict!) 😉

@WildCryptoFox
Copy link
Author

@Vinatorul I think @yo-bot needs to learn your labeling chore. 😉


Reoccurring that I see you manually setting these. I'm not used to having the permission to set these labels... I should get in a habit of it now.

@Vinatorul
Copy link
Contributor

Now it will get labeling job.
Tommorow bug fixing
Next weak new features implementation
And next month you will find yourself jobless!

Stop bots invasion! 😝

@WildCryptoFox
Copy link
Author

Ahh.. The Automation Takeover Begins.

@kbknapp
Copy link
Member

kbknapp commented Sep 10, 2015

👍 great work!

I'm ok with --some_option and the like so long as it's well documented. And also documented that they can just use the normal method when in doubt ;)

kbknapp added a commit that referenced this pull request Sep 10, 2015
@kbknapp kbknapp merged commit 091f096 into clap-rs:new-benches Sep 10, 2015
@Vinatorul
Copy link
Contributor

don't forget to use @yo-bot

epage added a commit that referenced this pull request Dec 7, 2021
fix: Limit when ui tests run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants