PRs accepted out of order #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Macro benchmarks
WildCryptoFox
added
C-enhancement
|
@Vinatorul @kbknapp As this was already accepted and applied out of order. Merging when Travis is happy. |
WildCryptoFox
pushed a commit
that referenced
this pull request
Sep 11, 2015
PRs accepted out of order
|
No worries, thanks for catching this! |
epage
added a commit
that referenced
this pull request
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#248 was meant to be accepted before #246 as #248 was configured to extend #246
The out of order merging has caused the old bench to go through without the patches.
The macro is still currently broken as it's patch has not been merged into master.