Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): Clean up remove types #3747

Merged
merged 1 commit into from
May 24, 2022
Merged

fix(parser): Clean up remove types #3747

merged 1 commit into from
May 24, 2022

Conversation

epage
Copy link
Member

@epage epage commented May 24, 2022

The remove functions no longer return Arc but the core type, at the
cost of requiring Clone. I originally held off on this
in #3732 in the hope of gracefully transition the derive and requiring
Clone would have been a breaking change but when it came to #3734, I didn't
find a way to make it work without a breaking change, so I made it
opt-in. This means I can force the Clone requirement now.

I added the requirement for Clone everywhere else in the hopes that in
the future, we can drop the Arc without a breaking change.

The remove functions no longer return `Arc` but the core type, at the
cost of requiring `Clone`.  I originally held off on this
in clap-rs#3732 in the hope of gracefully transition the derive and requiring
`Clone` would have been a breaking change but when it came to clap-rs#3734, I didn't
find a way to make it work without a breaking change, so I made it
opt-in.  This means I can force the `Clone` requirement now.

I added the requirement for `Clone` everywhere else in the hopes that in
the future, we can drop the `Arc` without a breaking change.
@epage epage merged commit 0c4a4f1 into clap-rs:master May 24, 2022
@epage epage deleted the clone branch May 24, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant