Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Clean up remove types #3747

Merged
merged 1 commit into from
May 24, 2022
Merged

fix(parser): Clean up remove types #3747

merged 1 commit into from
May 24, 2022

Commits on May 24, 2022

  1. fix(parser): Clean up remove types 

    The remove functions no longer return `Arc` but the core type, at the
cost of requiring `Clone`.  I originally held off on this
in clap-rs#3732 in the hope of gracefully transition the derive and requiring
`Clone` would have been a breaking change but when it came to clap-rs#3734, I didn't
find a way to make it work without a breaking change, so I made it
opt-in.  This means I can force the `Clone` requirement now.

I added the requirement for `Clone` everywhere else in the hopes that in
the future, we can drop the `Arc` without a breaking change.
    @epage
    epage committed May 24, 2022
    Configuration menu
    Copy the full SHA
    ed45de2 View commit details
    Browse the repository at this point in the history