Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): SetTrue/SetFalse/Count Actions #3775

Merged
merged 5 commits into from
Jun 1, 2022
Merged

feat(parser): SetTrue/SetFalse/Count Actions #3775

merged 5 commits into from
Jun 1, 2022

Commits on Jun 1, 2022

  1. feat(parser): SetTrue/SetFalse/Count Actions 

    This is the minimum set of actions for the derive to move off of
`parse`.  These are inspired by Python's native actions.

These new actions have a "unified" behavior with defaults/envs.  This
mostly means that occurrences aren't tracked.  Occurrences were used as
a substitute for `ValueSource` or for counting values.  Both cases
shouldn't be needed anymore but we can re-evaluate this later if needed.
    @epage
    epage committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    67f47c5 View commit details
    Browse the repository at this point in the history

  2. fix(parser): Apply conditional defaults 

    Now that we can store constants for flags, we can apply defaults for
flags too.

Fixes clap-rs#3294
    @epage
    epage committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    06ea572 View commit details
    Browse the repository at this point in the history

  3. fix(parser): Don't double-increment index on flags

    @epage
    epage committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4afd1aa View commit details
    Browse the repository at this point in the history

  4. test(parser): Ensure conditional requirements work with new Actions

    @epage
    epage committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2e9e556 View commit details
    Browse the repository at this point in the history

  5. style: Make clippy happy

    @epage
    epage committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    c58a802 View commit details
    Browse the repository at this point in the history