feat(parser): SetTrue/SetFalse/Count Actions #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimum set of actions for the derive to move off of `parse`. These are inspired by Python's native actions. These new actions have a "unified" behavior with defaults/envs. This mostly means that occurrences aren't tracked. Occurrences were used as a substitute for `ValueSource` or for counting values. Both cases shouldn't be needed anymore but we can re-evaluate this later if needed.
Now that we can store constants for flags, we can apply defaults for flags too. Fixes clap-rs#3294
This was referenced Jun 1, 2022
epage
added a commit
to epage/clap
that referenced
this pull request
Jun 6, 2022
This is the derive support for clap-rs#3774 (see also clap-rs#3775, clap-rs#3777) This combined with `value_parser` replaces `parser`. The main frustration with this is that `ArgAction::Count` (the replacement for `parse(from_occurrences)` must be a `u64`. We could come up with a magic attribute that is meant to be the value parser's parsed type. We could then use `TryFrom` to convert the parsed type to the user's type to allow more. That is an exercise for the future. Alternatively, we have clap-rs#3792. Prep for this included - clap-rs#3782 - clap-rs#3783 - clap-rs#3786 - clap-rs#3789 - clap-rs#3793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimum set of actions for the derive to move off of
parse. These are inspired by Python's native actions.These new actions have a "unified" behavior with defaults/envs. This
mostly means that occurrences aren't tracked. Occurrences were used as
a substitute for
ValueSourceor for counting values. Both casesshouldn't be needed anymore but we can re-evaluate this later if needed.
There is room for performance improvements where we reuse allocations but we can worry about that as a profiler says its a case to care about.
Now that we can store constants for flags, we can apply defaults for
flags too.
Fixes #3294