Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Prep for actions in derive #3789

Merged
merged 11 commits into from
Jun 4, 2022
Merged

refactor: Prep for actions in derive #3789

merged 11 commits into from
Jun 4, 2022

Commits on Jun 4, 2022

  1. chore: Make it easy to reproduce CI docs run

    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    d56d8dd View commit details
    Browse the repository at this point in the history

  2. fix(builder): Make it easier to discover/access ArgAction

    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    52e2874 View commit details
    Browse the repository at this point in the history

  3. test(derive): Improve help output assertions

    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    11fbe7e View commit details
    Browse the repository at this point in the history

  4. fix(help): Don't report flag defaults 

    Now that flags can have meaningful defaults and with defaults being
implicitly set for certain actions, they appear in help but don't quite
make sense.
    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    a3092ba View commit details
    Browse the repository at this point in the history

  5. test(derive): Verify doc comments on ArgEnum

    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    b09def1 View commit details
    Browse the repository at this point in the history

  6. fix(help): Output some bool possible values 

    Originally I hid all, assuming the flag-only use case but we had to
prevent that from showing up anyways.  For the takes_value case, we
should be showing something since we know what it accepts.  I decided to
only show the most basic values and hide the rest so as to not overwhelm
the user with redundant options and hope the user recognizes they are
redundant.
    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    ccd6663 View commit details
    Browse the repository at this point in the history

  7. refactor(parser): Clarify we are working with ids, not names

    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    5f56e93 View commit details
    Browse the repository at this point in the history

  8. test(parser): Verify indices of defaults 

    I thought I had broken this but it always seemed to have worked this way
    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    a971346 View commit details
    Browse the repository at this point in the history

  9. fix(error): Don't include default-but-required arguments in usage

    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    f3bc3d5 View commit details
    Browse the repository at this point in the history

  10. fix(parser): Exclusive shouldnt preclude defaults 

    Unsure why a comment said this doesn't matter.  It matters both for
counting arguments and for reporting the correct argument is exclusive.
    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    9638f33 View commit details
    Browse the repository at this point in the history

  11. test(derive): Update ui tests

    @epage
    epage committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    002204a View commit details
    Browse the repository at this point in the history