refactor: Prep for actions in derive #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that flags can have meaningful defaults and with defaults being implicitly set for certain actions, they appear in help but don't quite make sense.
Originally I hid all, assuming the flag-only use case but we had to prevent that from showing up anyways. For the takes_value case, we should be showing something since we know what it accepts. I decided to only show the most basic values and hide the rest so as to not overwhelm the user with redundant options and hope the user recognizes they are redundant.
I thought I had broken this but it always seemed to have worked this way
Unsure why a comment said this doesn't matter. It matters both for counting arguments and for reporting the correct argument is exclusive.
epage
added a commit
to epage/clap
that referenced
this pull request
Jun 6, 2022
This is the derive support for clap-rs#3774 (see also clap-rs#3775, clap-rs#3777) This combined with `value_parser` replaces `parser`. The main frustration with this is that `ArgAction::Count` (the replacement for `parse(from_occurrences)` must be a `u64`. We could come up with a magic attribute that is meant to be the value parser's parsed type. We could then use `TryFrom` to convert the parsed type to the user's type to allow more. That is an exercise for the future. Alternatively, we have clap-rs#3792. Prep for this included - clap-rs#3782 - clap-rs#3783 - clap-rs#3786 - clap-rs#3789 - clap-rs#3793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.