Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch to owned OsStr type #4096

Merged
merged 2 commits into from
Aug 19, 2022
Merged

fix: Switch to owned OsStr type #4096

merged 2 commits into from
Aug 19, 2022

Conversation

epage
Copy link
Member

@epage epage commented Aug 19, 2022

Another step towards #1041

This allowed removing a dependency as well which helps towards #2037

This is a part of clap-rs#1041

Because `Option<Into<T>>` is ambiguous for `None`, we had to create
`Resettable` to workaround it.
With being able to accept owned types now, `clap_derive` no longer needs
`once_cell` to make dynamic data static.

This helps towards clap-rs#1365, clap-rs#2037
@epage epage merged commit 99d3bb8 into clap-rs:master Aug 19, 2022
@epage epage deleted the raw branch August 19, 2022 17:13
epage added a commit to epage/clap that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant