Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Switch to owned OsStr type #4096

Merged
merged 2 commits into from
Aug 19, 2022
Merged

fix: Switch to owned OsStr type #4096

merged 2 commits into from
Aug 19, 2022

Commits on Aug 16, 2022

  1. fix: Switch OsStr's in builder to owned/borrowed type 

    This is a part of clap-rs#1041

Because `Option<Into<T>>` is ambiguous for `None`, we had to create
`Resettable` to workaround it.
    @epage
    epage committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    91e55c6 View commit details
    Browse the repository at this point in the history

  2. fix: Remove once_cell dependency from derive 

    With being able to accept owned types now, `clap_derive` no longer needs
`once_cell` to make dynamic data static.

This helps towards clap-rs#1365, clap-rs#2037
    @epage
    epage committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    429143a View commit details
    Browse the repository at this point in the history