Add shim to data collection script #680
Conversation
Sorted the list of problem regular expressions in the "cc-collect-data.sh" script to make maintenance easier. Signed-off-by: James O. D. Hunt <[email protected]>
Added a few more keywords denoting problems to search for in the "cc-collect-data.sh" script. Signed-off-by: James O. D. Hunt <[email protected]>
Create a find_system_journal_problems() function that is called by show_proxy_log_details() in the "cc-collect-data.sh" script. Signed-off-by: James O. D. Hunt <[email protected]>
Change "cc-collect-data.sh" to also capture any shim messages in the system log. Fixes clearcontainers#679. Signed-off-by: James O. D. Hunt <[email protected]>
|
kubernetes qa-passed 👍 |
| @@ -164,6 +164,7 @@ show_log_details() | |||
|
|
|||
| show_runtime_log_details | |||
| show_proxy_log_details | |||
| show_shim_log_details | |||
There was a problem hiding this comment.
A query - did you manage to get shim debug/details into the logs? I recently saw we have a debug ability in the shim:
https://github.com/clearcontainers/shim/blob/5da156955ebb4c001b5f89f1de11db3ca916228e/src/shim.c#L992
but could find no way for us to invoke that through the runtime/proxy code. If there is a way, we should add it to the debugging docs that we are building.
/cc @amshinde
There was a problem hiding this comment.
Ugh - I've just realised the code here is wrong for the shim. I'll raise a follow-up to resolve that.
Regarding enabling debug for cc-shim, I've just raised containers/virtcontainers#402. Once that lands we can re-vendor the runtime and add a new option in the config file for shim debug.
Instead of using a default queue size of 8 for macvtap fds, use the number of CPUs on the guest as the queue size. This is the recommended approach. This also shown better performance results. Fixes clearcontainers#680 Signed-off-by: Archana Shinde <[email protected]>
No description provided.