This repository has been archived by the owner on May 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 70
Add shim to data collection script #680
Merged
grahamwhaley
merged 4 commits into
clearcontainers:master
from
jodh-intel:add-shim-to-data-collection-script
Oct 6, 2017
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dad00e7
scripts: Sort problem regex in data collection script
jodh-intel c6efaf6
scripts: Added more problem regexes to data collection script
jodh-intel 70bcd91
scripts: Refactor system journal code in data collection script
jodh-intel bfc2752
scripts: Add shim logs to data collection script
jodh-intel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A query - did you manage to get shim debug/details into the logs? I recently saw we have a debug ability in the shim:
https://github.com/clearcontainers/shim/blob/5da156955ebb4c001b5f89f1de11db3ca916228e/src/shim.c#L992
but could find no way for us to invoke that through the runtime/proxy code. If there is a way, we should add it to the debugging docs that we are building.
/cc @amshinde
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh - I've just realised the code here is wrong for the shim. I'll raise a follow-up to resolve that.
Regarding enabling debug for
cc-shim
, I've just raised containers/virtcontainers#402. Once that lands we can re-vendor the runtime and add a new option in the config file for shim debug.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on #682.