fix(clerk-js): SignIn/SignUp component spacing adjustment #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c454ad8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!preview |
octoper
force-pushed
the
vaggelis/signin-signup-spacing-fixes
branch
from
609d90b
to
ab1f1f2
Compare
|
Hey @octoper, your preview is available.
|
anagstef
reviewed
Feb 5, 2024
| justifyContent: 'center', | ||
| alignContent: 'center', | ||
| }), | ||
| sx, | ||
| ]} | ||
| gap={gap} |
There was a problem hiding this comment.
🙃 This could be gap={8} without decontructing it from the rest of the props.
anagstef
reviewed
Feb 5, 2024
Comment on lines
36
to
37
| <Header.Root showLogo> | ||
| <Card.Alert>{card.error}</Card.Alert> |
There was a problem hiding this comment.
Why is the error inside the Header? On all the other screens, the error is outside the Header.Root component. 🤔
anagstef
approved these changes
Feb 5, 2024
octoper
force-pushed
the
vaggelis/signin-signup-spacing-fixes
branch
from
ab1f1f2
to
51d8811
Compare
|
!preview |
|
!preview |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies some last fixes to align implementations with designs.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore