Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Application logo rendering size #3959

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Aug 14, 2024

Description

Fixes issue where application logos were rendering smaller then intended. Reverts the changes to application logo from #2716

Fixes SDKI-576

Square logo:

Screenshot 2024-08-14 at 3 53 42 PM

Horizontal logo:

Screenshot 2024-08-14 at 3 54 36 PM

Vertical logo:

Screenshot 2024-08-14 at 3 55 27 PM

Clerk logo before and after:

Before After
Screenshot 2024-08-14 at 3 58 19 PM Screenshot 2024-08-14 at 3 58 28 PM

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 7f18829

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@octoper octoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@octoper octoper force-pushed the alexcarpenter/sdki-576-logo-display-height-super-small branch from a1217c3 to 7f18829 Compare August 16, 2024 10:22
@LekoArts LekoArts merged commit d36b0e1 into main Aug 16, 2024
18 checks passed
@LekoArts LekoArts deleted the alexcarpenter/sdki-576-logo-display-height-super-small branch August 16, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants