Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scr-target-branch is required, and dockerfile change should trigger rebuild #66

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

jameshochadel
Copy link
Contributor

Changes proposed in this pull request:

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@jameshochadel jameshochadel requested a review from a team March 7, 2024 15:14
@jameshochadel jameshochadel merged commit daa6428 into main Mar 7, 2024
@jameshochadel jameshochadel deleted the csb-docker branch March 7, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants