Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Jetty Http Request/Response Header Size Configuration #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide Jetty Http Request/Response Header Size Configuration #266

wants to merge 1 commit into from

Conversation

brockn
Copy link

@brockn brockn commented Dec 30, 2016

Kerberos over http requires larger header sizes than the default,
or the HTTP Error 413 Request entity too large will be returned.
This patch increases the default for Livy to 128K and also allows
this to be configurable.

Kerberos over http requires larger header sizes than the default,
or the HTTP Error 413 Request entity too large will be returned.
This patch increases the default for Livy to 128K and also allows
this to be configurable.
@codecov-io
Copy link

Current coverage is 71.00% (diff: 81.81%)

Merging #266 into master will decrease coverage by 0.08%

@@             master       #266   diff @@
==========================================
  Files            92         92          
  Lines          4749       4759    +10   
  Methods           0          0          
  Messages          0          0          
  Branches        822        822          
==========================================
+ Hits           3376       3379     +3   
- Misses          899        905     +6   
- Partials        474        475     +1   

Powered by Codecov. Last update 6077628...dc97af3

@@ -58,6 +58,8 @@ object LivyConf {

val SERVER_HOST = Entry("livy.server.host", "0.0.0.0")
val SERVER_PORT = Entry("livy.server.port", 8998)
val HTTP_REQUEST_HEADER_SIZE = Entry("livy.http.request.header.size", 131072)
val HTTP_RESPONSE_HEADER_SIZE = Entry("livy.http.response.header.size", 131072)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the configurations to "livy.server.request_header.size" and "livy.server.response_header.size", also it would be better to add some comments for these two configurations to describe why we have to change the default size.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

livy.server.request-header.size
livy.server.response-header.size


case Some(keystore) =>
val https = new HttpConfiguration()
https.setRequestHeaderSize(requestHeaderSize)
https.setResponseHeaderSize(responseHeaderSize)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this HttpConfiguration to above to remove the duplications.

@alex-the-man alex-the-man added this to the 0.3 milestone Jan 3, 2017
@alex-the-man
Copy link
Contributor

alex-the-man commented Jan 3, 2017

Mind if you create a JIRA for this?

@jerryshao
Copy link
Contributor

@brockn Would you mind addressing the comments mentioned above?

@zjffdu
Copy link
Contributor

zjffdu commented May 11, 2017

@brockn Any update ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants