Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-358. Make JettyServer Http request and response header size configurable #329

Merged
merged 2 commits into from
May 12, 2017

Conversation

jerryshao
Copy link
Contributor

This patch is based on #266 , mainly to fix header size too large problem in spnego enabled scenario.

  1. Increase the default header size.
  2. Make header size configurable.

Brock Noland and others added 2 commits May 12, 2017 14:35
Kerberos over http requires larger header sizes than the default,
or the HTTP Error 413 Request entity too large will be returned.
This patch increases the default for Livy to 128K and also allows
this to be configurable.
Change-Id: Id274c8cc60d30e5d778f9c447502b7e7a789a8f0
@jerryshao jerryshao closed this May 12, 2017
@jerryshao jerryshao reopened this May 12, 2017
@codecov-io
Copy link

codecov-io commented May 12, 2017

Codecov Report

Merging #329 into master will decrease coverage by 0.06%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
- Coverage     70.55%   70.48%   -0.07%     
+ Complexity      726      724       -2     
============================================
  Files            96       96              
  Lines          5121     5123       +2     
  Branches        774      774              
============================================
- Hits           3613     3611       -2     
- Misses          990      995       +5     
+ Partials        518      517       -1
Impacted Files Coverage Δ Complexity Δ
...er/src/main/scala/com/cloudera/livy/LivyConf.scala 94.35% <100%> (-0.09%) 16 <0> (ø)
...ain/scala/com/cloudera/livy/server/WebServer.scala 59.61% <66.66%> (-0.81%) 9 <0> (ø)
rsc/src/main/java/com/cloudera/livy/rsc/Utils.java 83.33% <0%> (-2.39%) 16% <0%> (ø)
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 76.29% <0%> (-2.16%) 39% <0%> (-1%)
...c/src/main/java/com/cloudera/livy/rsc/rpc/Rpc.java 77.98% <0%> (-0.63%) 12% <0%> (ø)
.../java/com/cloudera/livy/rsc/driver/JobWrapper.java 80.64% <0%> (ø) 7% <0%> (-1%) ⬇️
...in/java/com/cloudera/livy/rsc/ContextLauncher.java 83.08% <0%> (+2.48%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d51e998...fff004c. Read the comment docs.

@zjffdu
Copy link
Contributor

zjffdu commented May 12, 2017

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants