Enumerate service modes with explicit values #1249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our current type for the
Mode
field on theServiceModeV2
struct is a string. This allows for arbitrary strings, which are not supported service modes.The
Mode
field now uses a newServiceMode
string type that has constant values that can be assigned. These values are all of the existing service modes.Has your change been tested?
The underlying
Mode
type has not changed, so we don't need to augment the current tests.Types of changes
Checklist: