Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate service modes with explicit values #1249

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

imdawon
Copy link
Contributor

@imdawon imdawon commented Mar 27, 2023

Description

Our current type for the Mode field on the ServiceModeV2 struct is a string. This allows for arbitrary strings, which are not supported service modes.

The Mode field now uses a new ServiceMode string type that has constant values that can be assigned. These values are all of the existing service modes.

Has your change been tested?

The underlying Mode type has not changed, so we don't need to augment the current tests.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

changelog detected ✅

.changelog/1249.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 69d0870 into cloudflare:master Mar 28, 2023
@github-actions github-actions bot added this to the v0.64.0 milestone Mar 28, 2023
github-actions bot pushed a commit that referenced this pull request Mar 28, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.64.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants