Add WarningAggregator, improve unused stream warning #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unused stream warning emitted when a tee'd branch of an internal stream is left unconsumed is spammy and not very helpful. This change improves things by ensuring that only one instance of the warning per IoContext is emitted, aggregating all of the information about branches that are not read. The warning message is further augmented to include the JavaScript stack trace locations where each of the unconsumed branches were created.
jasnell
requested review from
irvinebroque,
kentonv,
mrbbot and
dario-piotrowicz
|
Nice one! LGTM |
mrbbot
reviewed
Mar 11, 2024
jasnell
commented
Mar 11, 2024
mrbbot
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EW-8204
The unused stream warning emitted when a tee'd branch of an internal stream is left unconsumed is spammy and not very helpful. This change improves things by ensuring that only one instance of the warning per IoContext is emitted, aggregating all of the information about branches that are not read. The warning message is further augmented to include the JavaScript stack trace locations where each of the unconsumed branches were created.