Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WarningAggregator, improve unused stream warning #1790

Merged
merged 2 commits into from
Mar 11, 2024

Commits on Mar 8, 2024

  1. Add WarningAggregator, improve unused stream warning

    The unused stream warning emitted when a tee'd branch of an internal
    stream is left unconsumed is spammy and not very helpful. This change
    improves things by ensuring that only one instance of the warning per
    IoContext is emitted, aggregating all of the information about branches
    that are not read. The warning message is further augmented to include
    the JavaScript stack trace locations where each of the unconsumed
    branches were created.
    jasnell committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    a95673c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    af1742a View commit details
    Browse the repository at this point in the history