on by default: –x-dev-env #6408

RamIdeas · 2024-08-02T15:43:44Z

What this PR solves / how to test

This PR updates the default value for --x-dev-env for wrangler dev (not yet for wrangler pages dev).

It also updates the e2e tests (which assumed the default value was false) to explicitly test with the flag on + off (TODO: need to update the snapshots because this changed the test names)

Author has addressed the following

Tests
- TODO (before merge)
- Tests included
- Not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Changeset (Changeset guidelines)
- TODO (before merge)
- Changeset included
- Not necessary because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: experimental flag

changeset-bot · 2024-08-02T15:43:48Z

🦋 Changeset detected

Latest commit: 374bdf4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-08-02T15:47:37Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-wrangler-6408

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6408/npm-package-wrangler-6408

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-wrangler-6408 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-create-cloudflare-6408 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-cloudflare-kv-asset-handler-6408

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-miniflare-6408

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-cloudflare-pages-shared-6408

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-cloudflare-vitest-pool-workers-6408

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-cloudflare-workers-editor-shared-6408

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11128655826/npm-package-cloudflare-workers-shared-6408

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20240925.0
`workerd`	1.20240925.0	1.20240925.0
`workerd --version`	1.20240925.0	2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

packages/wrangler/src/api/startDevWorker/RemoteRuntimeController.ts

penalosa · 2024-09-27T13:02:12Z

packages/wrangler/src/api/startDevWorker/ConfigController.ts

+						: "http",
+		});
+
+		if (typeof vitest === "undefined") {


change to env var to disable watching

penalosa · 2024-09-27T13:02:40Z

packages/wrangler/src/api/startDevWorker/ConfigController.ts

-		} catch (err) {
-			logger.error(err);
+		const assets = processAssetsArg({ assets: input?.assets }, fileConfig);
+		if (assets && typeof vitest === "undefined") {


packages/wrangler/e2e/__snapshots__/pages-dev.test.ts.snap

RamIdeas · 2024-10-01T10:25:31Z

packages/wrangler/src/dev/remote.tsx

-	env?: string;
-	legacyEnv?: boolean;
-	host?: string;
+	env: string | undefined;
+	legacyEnv: boolean | undefined;
+	host: string | undefined;
 	routes: Route[] | undefined;
-	sendMetrics?: boolean;
+	sendMetrics: boolean | undefined;


This will prevent that missing host prop from happening again 👍

RamIdeas · 2024-10-01T10:30:18Z

I can't approve my own PR – but LGTM! ✅

emily-shen · 2024-10-01T13:40:13Z

packages/wrangler/src/assets.ts

@@ -361,40 +363,66 @@ export function processAssetsArg(
 *     - an asset binding cannot be used in a Worker that only has assets
 * and throw an appropriate error if invalid.
 */
+export function validateAssetsArgsAndConfig(


just making sure i've got this right, args in the first overload is after config and args have been combined?

emily-shen · 2024-10-01T13:40:29Z

packages/wrangler/src/__tests__/deploy.test.ts

@@ -4303,6 +4303,31 @@ addEventListener('fetch', event => {});`
 			);
 		});

+		it("should error if --assets and config.tail_consumers are used together", async () => {


thanks for adding these in :)

These 2 tests were moved from dev.test.ts(x)

emily-shen

thanks for tidying up the assets/legacy assets options

… value)

RamIdeas requested a review from a team as a code owner August 2, 2024 15:43

workers-devprod added the e2e Run e2e tests on a PR label Aug 2, 2024

RamIdeas mentioned this pull request Aug 6, 2024

Update e2e tests to use startWorker directly #6409

Merged

12 tasks

penalosa force-pushed the default-dev-env branch 2 times, most recently from 26b3311 to 2092945 Compare September 27, 2024 01:56

penalosa reviewed Sep 27, 2024

View reviewed changes

packages/wrangler/src/api/startDevWorker/RemoteRuntimeController.ts Show resolved Hide resolved

penalosa reviewed Sep 27, 2024

View reviewed changes

edmundhung reviewed Sep 30, 2024

View reviewed changes

packages/wrangler/e2e/__snapshots__/pages-dev.test.ts.snap Show resolved Hide resolved

RamIdeas commented Oct 1, 2024

View reviewed changes

emily-shen reviewed Oct 1, 2024

View reviewed changes

emily-shen approved these changes Oct 1, 2024

View reviewed changes

RamIdeas and others added 10 commits October 1, 2024 16:03

on by default: --x-dev-env

e69c466

ensure e2e tests run with explicit flag values (regardless of default…

5fcf8f8

… value)

add changeset

449fbc7

udate snapshots

4f14f08

🔴→💚

6a9d5ee

🖥️+⌨️

4d40c11

fix --remote w/ host & w/ empty routes

b415cf8

fixes

043e2e5

fix assets e2e

c1e727c

fix lint

374bdf4

RamIdeas force-pushed the default-dev-env branch 2 times, most recently from c0f93db to 374bdf4 Compare October 1, 2024 15:34

RamIdeas merged commit 3fa846e into main Oct 1, 2024
24 checks passed

RamIdeas deleted the default-dev-env branch October 1, 2024 17:49

workers-devprod mentioned this pull request Oct 1, 2024

Version Packages #6875

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

on by default: –x-dev-env #6408

on by default: –x-dev-env #6408

RamIdeas commented Aug 2, 2024 •

edited by penalosa

Loading

changeset-bot bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

penalosa Sep 27, 2024

penalosa Sep 27, 2024

RamIdeas Oct 1, 2024

RamIdeas commented Oct 1, 2024

emily-shen Oct 1, 2024

emily-shen Oct 1, 2024

RamIdeas Oct 1, 2024

emily-shen left a comment •

edited

Loading

on by default: –x-dev-env #6408

on by default: –x-dev-env #6408

Conversation

RamIdeas commented Aug 2, 2024 • edited by penalosa Loading

What this PR solves / how to test

Author has addressed the following

changeset-bot bot commented Aug 2, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Aug 2, 2024 • edited Loading

penalosa Sep 27, 2024

Choose a reason for hiding this comment

penalosa Sep 27, 2024

Choose a reason for hiding this comment

RamIdeas Oct 1, 2024

Choose a reason for hiding this comment

RamIdeas commented Oct 1, 2024

emily-shen Oct 1, 2024

Choose a reason for hiding this comment

emily-shen Oct 1, 2024

Choose a reason for hiding this comment

RamIdeas Oct 1, 2024

Choose a reason for hiding this comment

emily-shen left a comment • edited Loading

Choose a reason for hiding this comment

RamIdeas commented Aug 2, 2024 •

edited by penalosa

Loading

changeset-bot bot commented Aug 2, 2024 •

edited

Loading

github-actions bot commented Aug 2, 2024 •

edited

Loading

emily-shen left a comment •

edited

Loading