-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update e2e tests to use startWorker directly #6409
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-wrangler-6409 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6409/npm-package-wrangler-6409 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-wrangler-6409 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-create-cloudflare-6409 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-cloudflare-kv-asset-handler-6409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-miniflare-6409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-cloudflare-pages-shared-6409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-cloudflare-vitest-pool-workers-6409 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
We should get this green and landed before we flip the --x-dev to default to on. cc @RamIdeas |
Cool. But also before we actually flip the default I would like to understand (and ideally fix) why the file based registry is not compatible with some of these fixtures when this flag is on. |
* update e2e tests to use startWorker directly instead of via DevEnv.startWorker
What this PR solves / how to test
Update e2e tests to use startWorker directly instead of DevEnv.startWorker
startWorker is the public interface whereas DevEnv provides access to internals (controllers) for advanced use-cases with APIs that we will iterate on and do not want to commit to yet.
Author has addressed the following