Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e tests to use startWorker directly #6409

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Aug 2, 2024

What this PR solves / how to test

Update e2e tests to use startWorker directly instead of DevEnv.startWorker

startWorker is the public interface whereas DevEnv provides access to internals (controllers) for advanced use-cases with APIs that we will iterate on and do not want to commit to yet.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: test change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@RamIdeas RamIdeas requested a review from a team as a code owner August 2, 2024 16:04
Copy link

changeset-bot bot commented Aug 2, 2024

⚠️ No Changeset found

Latest commit: 57a388d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Aug 2, 2024
Copy link
Contributor

github-actions bot commented Aug 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-wrangler-6409

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6409/npm-package-wrangler-6409

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-wrangler-6409 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-create-cloudflare-6409 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-cloudflare-kv-asset-handler-6409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-miniflare-6409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-cloudflare-pages-shared-6409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10270550552/npm-package-cloudflare-vitest-pool-workers-6409

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240725.0
workerd 1.20240725.0 1.20240725.0
workerd --version 1.20240725.0 2024-07-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin
Copy link
Contributor

We should get this green and landed before we flip the --x-dev to default to on. cc @RamIdeas

@RamIdeas
Copy link
Contributor Author

RamIdeas commented Aug 6, 2024

We should get this green and landed before we flip the --x-dev to default to on. cc @RamIdeas

We can and will because the only fail is a flake (albeit repeatedly). But this is unrelated to flipping the default and that PR will need some test rewrites before landing

@petebacondarwin
Copy link
Contributor

Cool. But also before we actually flip the default I would like to understand (and ideally fix) why the file based registry is not compatible with some of these fixtures when this flag is on.

@RamIdeas RamIdeas merged commit 3ae16ac into main Aug 12, 2024
20 checks passed
@RamIdeas RamIdeas deleted the update-startWorker-e2e-tests branch August 12, 2024 11:23
edmundhung pushed a commit that referenced this pull request Aug 13, 2024
* update e2e tests to use startWorker directly instead of via DevEnv.startWorker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants