Fix workflows binding to create a workflow without arguments & miss match instance.id between wrangler local dev and production

[bruxodasilva]

Fixes WOR-317. Fixes #7135

With this PR, 2 bugs were fixed:

• Fix workflows binding to create a workflow without arguments. If no argument were passed, the wrangler local dev would fail. Now we validate that the arguments exist, and if not, manage the creation of the necessary variables.
• instance.id is now available in wrangler local dev synchronously, as in production, which makes it possible to now run the sample workflows starter project

Co-authored-by: Sidhartha Chatterjee [email protected]

---

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because: workflows does not have them
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: no modifications to the feature usage

[changeset-bot]

🦋 Changeset detected

Latest commit: 3fe3e32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/workflows-shared	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-wrangler-7225

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7225/npm-package-wrangler-7225

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-wrangler-7225 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-create-cloudflare-7225 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-cloudflare-kv-asset-handler-7225

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-miniflare-7225

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-cloudflare-pages-shared-7225

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-cloudflare-vitest-pool-workers-7225

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-cloudflare-workers-editor-shared-7225

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-cloudflare-workers-shared-7225

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11893466292/npm-package-cloudflare-workflows-shared-7225

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20241106.0
workerd	1.20241106.1	1.20241106.1
workerd --version	1.20241106.1	2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[Skye-31]

I'm a little confused on what the second change around the id is for - could you clarify? 🙂

[bruxodasilva]

I'm a little confused on what the second change around the id is for - could you clarify? 🙂

I am sorry for the noise. I identified a miss match between wrangler local dev and production, regarding the way you could access instance.id.
This commits were me trying to debug, and use CI to generate the wrangler build for me, until I learned how to do local builds with fixtures. TIL
The last commit address this issue.

[Skye-31]

Can see now how this makes the behaviour match prod better. Thanks

[bruxodasilva]

@penalosa can you take a look at this? This PR is really improve for our customers, as currently wrangler local dev is not working properly.

[penalosa]

@bruxodasilva could you add a regression test to the workflows fixture test (fixtures/workflow)?

[sidharthachatterjee]

Looks good. Thank you!