Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflows binding to create a workflow without arguments & miss match instance.id between wrangler local dev and production #7225

Merged
merged 18 commits into from
Nov 18, 2024
Merged

Fix workflows binding to create a workflow without arguments & miss match instance.id between wrangler local dev and production #7225

merged 18 commits into from
Nov 18, 2024
+50 −12

Commits on Nov 11, 2024

  1. fix workflows binding to create a workflow without arguments

    @bruxodasilva
    bruxodasilva committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    b914f31 View commit details
    Browse the repository at this point in the history

  2. prettify cleanup

    @bruxodasilva
    bruxodasilva committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    01f8ad4 View commit details
    Browse the repository at this point in the history

  3. added changeset

    @bruxodasilva
    bruxodasilva committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    9d98a7f View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Update packages/workflows-shared/src/binding.ts 

    Accepted setting default values

Co-authored-by: Somhairle MacLeòid <[email protected]>
    @bruxodasilva @penalosa
    bruxodasilva and penalosa authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0753154 View commit details
    Browse the repository at this point in the history

  2. pretttify run

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e6b0cdb View commit details
    Browse the repository at this point in the history

  3. Update packages/workflows-shared/src/binding.ts 

    Co-authored-by: Skye <[email protected]>
    @bruxodasilva @Skye-31
    bruxodasilva and Skye-31 authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5b1f6c8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into dferreira/workflows-fix-empty-create

    @bruxodasilva
    bruxodasilva authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    725806d View commit details
    Browse the repository at this point in the history

  5. try to get instance.id

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    335a288 View commit details
    Browse the repository at this point in the history

  6. new try

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    760f677 View commit details
    Browse the repository at this point in the history

  7. pretty

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    da87e97 View commit details
    Browse the repository at this point in the history

  8. - ensure .id is available on handle, syncronously

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d8214fa View commit details
    Browse the repository at this point in the history

  9. prettify

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3da1e18 View commit details
    Browse the repository at this point in the history

  10. updated changeset

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    98718af View commit details
    Browse the repository at this point in the history

  11. reverted workflows fixture

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    11cf707 View commit details
    Browse the repository at this point in the history

  12. better changeset

    @bruxodasilva
    bruxodasilva committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a033e75 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. reverted constructor sugar as per code review

    @bruxodasilva
    bruxodasilva committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b379a8b View commit details
    Browse the repository at this point in the history

  2. added regression test to the workflows fixture test

    @bruxodasilva
    bruxodasilva committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    519a22f View commit details
    Browse the repository at this point in the history

  3. prettify

    @bruxodasilva
    bruxodasilva committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    3fe3e32 View commit details
    Browse the repository at this point in the history