Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Chore: Don't panic in KV command mods #406

Closed
ashleymichal opened this issue Aug 6, 2019 · 4 comments
Closed

Chore: Don't panic in KV command mods #406

ashleymichal opened this issue Aug 6, 2019 · 4 comments
Assignees
Labels
regression Something is broken, but works in previous releases

Comments

@ashleymichal
Copy link
Contributor

We panic a lot across the code base, but there's no reason to do it in these new modules. let's clean it up before we go to master.

Per #405 (comment)

@ashleymichal ashleymichal added status - work in progress regression Something is broken, but works in previous releases labels Aug 6, 2019
@ashleymichal ashleymichal added this to the Add KV Subcommands milestone Aug 6, 2019
@ashleymichal ashleymichal self-assigned this Aug 6, 2019
@gabbifish gabbifish self-assigned this Aug 23, 2019
gabbifish added a commit that referenced this issue Aug 27, 2019
@gabbifish
Copy link
Contributor

Cleaned up our use of panic, as well as made our unwrap() calls in main.rs not risky (force .required(true) on args so Clap throws missing args before an unwrap() call for a missing arg could panic).

@ashleymichal
Copy link
Contributor Author

where?

@ashleymichal ashleymichal reopened this Aug 27, 2019
@gabbifish
Copy link
Contributor

This was fixed in the commit linked to above (these were small enough changes I pushed directly to the feature branch; in the future, I can still go through PRs for small changes?).

@ashleymichal
Copy link
Contributor Author

ashleymichal commented Aug 27, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
regression Something is broken, but works in previous releases
Projects
None yet
Development

No branches or pull requests

2 participants