-
Notifications
You must be signed in to change notification settings - Fork 337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. one small question but not a huge deal
1c02235
to
db8eb05
Compare
* implement From for cloudflare-rs Credential -> GlobalUser
* add KV emoji
db8eb05
to
b8bc14b
Compare
* Add more helpful messaging when creating namespace; output to put in wrangler.toml
* Print out namespaces list as json by default
* Add reminder to remove binding after calling , also ensure binding names are valid
* Re-order kv commands docs to be more user friendly + Add Getting Started and Concepts sections to kv docs
docs/content/environments.md
Outdated
@@ -218,6 +218,25 @@ name = "my-worker-staging" | |||
|
|||
Your default `wrangler build`, `wrangler preview`, and `wrangler publish` commands will all build with `webpack.dev.js`, as will `wrangler build -e staging`, `wrangler preview -e staging`, and `wrangler publish -e staging`. `wrangler build -e production`, `wrangler preview -e production`, and `wrangler publish -e production` would all use your `webpack.config.js` file. | |||
|
|||
### KV Namespaces with environments | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was renamed. I might be wrong but I believe I saw a link to this doc printed out in my terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct
@gabbifish do you mind updating the instances of /docs/environments.md to /docs/content/environments.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
Allow use of same json file to bulk delete as bulk put
* Ensure that when a subcommand is not provided to a kv: command, do not panic. STILL DISPLAYS HELP INFORMATION WITH --binding AND --namespace-id INFO THAT IS INCONSISTENT WITH USAGE (b/c globals are paired with arggroups here)
README.md
Outdated
@@ -46,7 +46,15 @@ General documentation surrounding workers development and using `wrangler` can b | |||
wrangler generate <name> <template> --type=["webpack", "javascript", "rust"] | |||
``` | |||
|
|||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve conflict in readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nooooo
README.md
Outdated
| route | The route you would like to publish to | `route = "example.com/my-worker/*"` | | ||
| zone_id | Your Cloudflare zone ID, this can be found in the Cloudflare dashboard | `zone_id = "b6558acaf2b4cad1f2b51c5236a6b972"` | | ||
|
||
>>>>>>> master | ||
#### Publishing the same code to multiple places | ||
|
||
If you would like to be able to publish your code to multiple places, please see the documentation for [environments](https://github.com/cloudflare/wrangler/blob/master/docs/environments.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all instances of docs/environments.md need to be changed to docs/content/environments.md
missed a couple merge conflicts. need new review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! great work :)
Closes #339. Comprises complete support for KV commands in Wrangler, should close https://github.com/cloudflare/wrangler/milestone/7 also.
keep this branch up to date with master using ui merges rather than rebasing.