This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Gabbi/url encode #507
Merged
Gabbi/url encode #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gabbifish
added
regression
ashleymichal
reviewed
Sep 3, 2019
src/main.rs
Outdated
| @@ -120,7 +120,7 @@ fn run() -> Result<(), failure::Error> { | |||
| ) | |||
| .arg( | |||
| Arg::with_name("expiration-ttl") | |||
| .help("Number of seconds for which the entries should be visible before they expire. At least 60. Takes precedence over 'expiration' option") | |||
| .help("Number of seconds for which the entries should be visible before they expire. At least 60") | |||
There was a problem hiding this comment.
did you mean to remove this?
There was a problem hiding this comment.
Oop! That is an accident. Fixing.
ashleymichal
approved these changes
Sep 3, 2019
gabbifish
commented
Sep 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #504. Since this change also impacts how KV command methods import the
url_encode_key()function from the mod.rs for the kv package, it also implements the change suggested here: #405 (comment)