-
Notifications
You must be signed in to change notification settings - Fork 337
[dev] Handles cf-ew-raw- headers #884
[dev] Handles cf-ew-raw- headers #884
Conversation
f1e4c2d
to
6a5a226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small request!
2270767
to
4b5f367
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits as well as suggestions for moving variables around :)
src/commands/dev/mod.rs
Outdated
) | ||
let client = client.to_owned(); | ||
let preview_id = preview_id.to_owned(); | ||
let server_config = server_config.clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to clone this twice? (once in line 49, once here?) I feel like we can put variables like client, preview_id, and server_config in the arguments section move |args|
and avoid unnecessary clones :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!!
Fixes #873
worker code returns stringified headers in the response body: