Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Make Eirini apps work with our DNS #284

Closed
f0rmiga opened this issue Dec 21, 2019 · 9 comments · Fixed by #1275
Closed

Make Eirini apps work with our DNS #284

f0rmiga opened this issue Dec 21, 2019 · 9 comments · Fixed by #1275
Labels
changelog Issue must be present in the release notes. Priority: Medium Status: Done Implemented and PR merged SUSE SUSE is pursuing a solution suse-cap Type: Bug Something isn't working
Milestone

Comments

@f0rmiga
Copy link
Member

f0rmiga commented Dec 21, 2019

Describe the bug

Since Eirini apps cannot resolve the DNS records from the kubecf coreDNS instance, credhub.servie.cf.internal becomes unreachable.

To Reproduce

Deploy kubecf with Eirini and check that credhub CATS suite doesn't pass.

Expected behavior

Eirini apps should be able to resolve the kubecf DNS entries. It may be possible with an EiriniX mutator.

Environment

All versions.

@f0rmiga f0rmiga added Type: Bug Something isn't working Priority: High labels Dec 21, 2019
@f0rmiga f0rmiga added this to the 0.2.0 milestone Dec 21, 2019
@fargozhu fargozhu added the SUSE SUSE is pursuing a solution label Jan 7, 2020
@f0rmiga f0rmiga added Type: Spike and removed Type: Bug Something isn't working labels Jan 8, 2020
@f0rmiga f0rmiga changed the title Credhub doesn't work with Eirini apps Make Eirini apps work with our DNS Jan 8, 2020
@f0rmiga f0rmiga added the Status: Blocked Dependencies on other issues and/or pull requests label Jan 8, 2020
@f0rmiga f0rmiga added Status: Blocked Dependencies on other issues and/or pull requests and removed Status: Blocked Dependencies on other issues and/or pull requests labels Jan 8, 2020
@f0rmiga f0rmiga self-assigned this Jan 17, 2020
@f0rmiga f0rmiga added the Status: Blocked Dependencies on other issues and/or pull requests label Jan 22, 2020
@f0rmiga
Copy link
Member Author

f0rmiga commented Jan 22, 2020

@f0rmiga f0rmiga modified the milestones: 0.2.0, 1.0.0 Jan 23, 2020
@f0rmiga f0rmiga removed the Status: Blocked Dependencies on other issues and/or pull requests label Jan 24, 2020
@f0rmiga
Copy link
Member Author

f0rmiga commented Jan 24, 2020

I currently got an Eirinix working for mutating the apps, pointing them to the kubecf custom DNS instances. credhub tests fail due to, apparently, trying to set an environment variable at runtime. Since k8s doesn't support this behaviour without restarting, I'm in the process of finding out if the failing credhub tests are relevant in the Eirini world.

@fargozhu fargozhu added the Status: Blocked Dependencies on other issues and/or pull requests label Jan 31, 2020
@fargozhu fargozhu removed this from the 1.0.0 milestone Feb 3, 2020
@f0rmiga f0rmiga removed their assignment May 19, 2020
@viovanov viovanov added suse-cap Type: Bug Something isn't working labels Jun 25, 2020
@mook-as mook-as self-assigned this Jun 30, 2020
@fargozhu fargozhu added this to the jumanji milestone Jul 8, 2020
@mook-as
Copy link
Contributor

mook-as commented Jul 9, 2020

@mook-as
Copy link
Contributor

mook-as commented Jul 10, 2020

This is going to involved cloudfoundry-incubator/eirinix#40 — eirinix has really old quarks dependencies. (It still refers to cf-operator in the import, which makes it not build.)

@jandubois
Copy link
Member

(It still refers to cf-operator in the import, which makes it not build.)

If you need a quick fix for building it, here is what I did in https://github.com/SUSE/eirini-persi/blob/master/go.mod#L25

@mook-as
Copy link
Contributor

mook-as commented Aug 21, 2020

PR posted in SUSE/eirini-dns-aliases#1

Required changes to test:

  • Add chart to deploy/helm/kubecf/requirements.yaml; something like
- name: eirini-dns-aliases
  repository: https://mook-as.github.io/eirini-dns-aliases/
  version: v0.0.0-dev+10-gcc1efd5
  condition: features.eirini.enabled
  • Run dev/helm/update_subcharts.sh
  • Add configuration to values.yaml, or one of the newfangled config files:
eirini-dns-aliases:
  deployment:
    eirini_namespace: eirini

Test by hijacking into one of the eirini-deployed apps (eirini-ssh seems busted again for me), and run curl -k https://credhub:8844/ — you should get a JSON response back.

@f0rmiga f0rmiga mentioned this issue Sep 1, 2020
3 tasks
@mook-as mook-as removed their assignment Sep 4, 2020
@andreas-kupries andreas-kupries added the Status: Blocked Dependencies on other issues and/or pull requests label Sep 10, 2020
@andreas-kupries
Copy link
Contributor

Blocked on its PR, which is blocked in turn on #1259

@mook-as I notice that #1259 is merged. Would this unblock the linked #1275 ?

@mook-as
Copy link
Contributor

mook-as commented Sep 10, 2020

@andreas-kupries I believe #1275 is currently waiting on SUSE/eirini-dns-aliases#1

@andreas-kupries
Copy link
Contributor

Ok then. Marking it as blocked was correct.

@fargozhu fargozhu added changelog Issue must be present in the release notes. Status: Done Implemented and PR merged and removed Status: Blocked Dependencies on other issues and/or pull requests Status: WIP Type: Spike labels Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog Issue must be present in the release notes. Priority: Medium Status: Done Implemented and PR merged SUSE SUSE is pursuing a solution suse-cap Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants