This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
feat: scripts/image_list: support VALUES override #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes all rubocop warnings (excluding Metrics/*). No functional change.
This adds support for the VALUES override when building the image list. This is helpful when testing local changes to be able to customize the list of images that will be needed (so they can be traferred to the kubernetes cluster). This should not be used in CI builds.
jandubois
reviewed
Sep 3, 2020
| @@ -53,23 +67,20 @@ def deep_populate_nil_values(hash) | |||
| } | |||
|
|
|||
| # Process the non-BOSH releases. | |||
| values['releases'].keys.each do |release_name| | |||
| values.releases.keys.each do |release_name| | |||
| # Filter out the 'defaults' key as it's not a release. | |||
| next if release_name == 'defaults' | |||
There was a problem hiding this comment.
This should be $defaults now, for correctness. In practice it doesn't matter because the default entry will not have an image key, so will be skipped in the next condition.
jandubois
approved these changes
Sep 3, 2020
mook-as
added a commit
that referenced
this pull request
Sep 4, 2020
The default release name (since the stacks change) is now $defaults rather than defaults. Addresses #1290 (comment)
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for the
VALUESoverride when building the image list. This is helpful when testing local changes to be able to customize the list of images that will be needed (so they can be traferred to the kubernetes cluster). This should not be used in CI builds.Note that most of the changes are to make rubocop happy.
Motivation and Context
While working on #284 I needed to set an override for the image for a new thing that we are not publishing yet (to use my WIP image). That means I need to provide overrides, but that wasn't possible with the way we were doing the image list.
How Has This Been Tested?
Ran locally, and loaded all the resulting images into minikube.
Types of changes
Checklist: