Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bbl-up task #155

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix: bbl-up task #155

merged 1 commit into from
May 5, 2023

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented May 4, 2023

What is this change about?

Calls terraform init in bbl-up task if DELETE_TERRAFORM_PLUGINS is set to false. This should ensure that certain bbl commands, that require the correct plugins, work

Please provide contextual information.

cloudfoundry/bosh-bootloader#560

Please check all that apply for this PR:

  • introduces a new task
  • changes an existing task
  • changes the Dockerfile
  • introduces a breaking change (other users will need to make manual changes when this is released)

Did you update the README as appropriate for this change?

  • YES
  • N/A

How should this change be described in release notes?

Fix issues related to running certain bbl commands by running terraform init beforehand.

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

None

@ctlong ctlong requested a review from a team May 4, 2023 02:48
@ctlong
Copy link
Member Author

ctlong commented May 4, 2023

This is a bit risky adding it straight to the setup_bosh_env_vars shared-function because we use it everywhere. I didn't want to track down all the places we need this terraform init though. If it's too much risk I could instead just add it to the generate-drats-config task in runtime-ci and we can add it more places wherever things break

Edit: changed the bbl-up task instead, which felt less risky and like a more long-lived solution.

@ctlong ctlong marked this pull request as draft May 4, 2023 17:36
@ctlong
Copy link
Member Author

ctlong commented May 4, 2023

I want to try adding the correct providers to the .terraform folders first and see if that works

Edit: it worked

Runs `terraform init` if we're not deleting the terraform plugins, in
order to make sure that all of the relevant plugins have been downloaded
(at least for the architecture of the concourse container, likely
linux).

See cloudfoundry/bosh-bootloader#560 for more
info.
@ctlong ctlong changed the title Fix: BBL setup in shared-functions Fix: bbl-up task May 4, 2023
@ctlong ctlong marked this pull request as ready for review May 4, 2023 20:58
@ctlong
Copy link
Member Author

ctlong commented May 4, 2023

We might be able to undo this change down the line once bbl cuts a new release that includes cloudfoundry/bosh-bootloader#563.

There's no requirement that we do so, it should continue to work at that point. However, these plugin files are quite large, ~70MB, so it's not ideal to be uploading and downloading them all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants