Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call "terraform init" before "bbl lbs" / "bbl outputs" #205

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jochenehret
Copy link
Contributor

* use image with latest bbl and Terraform versions: https://github.com/cloudfoundry/bosh-bootloader/blob/main/ci/dockerfiles/deployment/Dockerfile
* temporarily deployed to "appruntimedeployments" repository until https://hub.docker.com/r/cfinfrastructure/deployment is updated again
@jochenehret jochenehret requested a review from a team May 8, 2023 07:07
@jochenehret jochenehret marked this pull request as draft May 8, 2023 13:19
@jochenehret jochenehret changed the title Use latest bbl docker image version Call "terraform init" before "bbl lbs" / "bbl outputs" May 8, 2023
@@ -4,7 +4,8 @@ platform: linux
image_resource:
type: docker-image
source:
repository: cloudfoundry/cf-deployment-concourse-tasks
repository: appruntimedeployments/bbl-deployment
tag: v9.0.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctlong
Copy link
Member

ctlong commented May 8, 2023

One alternative to adding terraform init everywhere might be to set DELETE_TERRAFORM_PLUGINS to false in the bbl-up jobs. See this PR in cf-d-c-t for more details.

Doing so would mean that we only have this terraform init call in one place, if/when we eventually look to rip it out. On the flip side though, adding these ~70MB plugins all over relint-envs is going to slow down pulling and pushing that resource.

@jochenehret
Copy link
Contributor Author

When this bbl commit is released, we can probably remove our own terraform init calls again:
cloudfoundry/bosh-bootloader@ad241f7

@ctlong
Copy link
Member

ctlong commented May 9, 2023

My approach with saving the terraform plugin doesn't appear to be working..

@ctlong ctlong force-pushed the test_latest_bbl_docker_image branch from 5053e0c to ad79ff6 Compare May 9, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants