Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce nginx configuration for rate limiting #657

Merged
merged 1 commit into from
Aug 10, 2016

Conversation

suhlig
Copy link
Contributor

@suhlig suhlig commented Aug 2, 2016

Thanks for contributing to the cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

    This change introduces rate limiting to API calls to the Cloud Controller by exposing the limit_req nginx configuration setting. The rate limiting proposed is applied per user, using nginx' $http_authorization variable.

  • An explanation of the use cases your change solves

    It will prevent overloading the cloud controller with too many requests. It protects legit requests by applying the limit per-user.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests on bosh lite

Please note that the change was implemented by @petergtz and @jordanj.

@smoser-ibm & @suhlig from the Flintstone team

@cfdreddbot
Copy link

Hey suhlig!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/127533505

The labels on this github issue will be updated when the story is started.

@thausler786
Copy link
Contributor

Hey @suhlig,

Thanks for the pull request. We tested it out and were able to get it to successfully rate limit, and it passes our test suites when unconfigured.

Merged!

@thausler786
CAPI team member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants