Fix for rate limiting. nginx sublocations do not inherit all paramete… #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs from upper level. Therefore, duplicating the one parameter not inherited
|
Hey suhlig! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/133338405 The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
See pull request Introduce nginx configuration for rate limiting #657. @joachimjordan worked on this together with me and @petergtz. We noticed that when rate limiting is activated, this breaks the nginx config. Reason is that nginx does not document for each parameter if it is inherited by sub locations. The proxy_pass parameter is not inherited and thus must be duplicated for sublocations.
An explanation of the use cases your change solves
This fix adds the duplication for the proxy_pass parameter to the sublocations. Do you also require a test to ensure that this is working correctly? To test this, a CF installation is necessary with properties for the rate limiting added to the deployment manifest.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests on bosh lite