[Feature]: CFServiceInstance and CFServiceBinding resources should implement the ProvisionedService duck type

[tcdowney]

Blockers/Dependencies

No response

Background

As an App Developer
I want the CFServiceInstance and CFServiceBinding resources to implement the ProvisionedService duck type from the K8s Service Binding specification
So that they can interoperate with other K8s Service Binding aware projects (such as Kpack)

Acceptance Criteria

CFServiceInstance

Secret Exists

GIVEN I have applied a CFServiceInstance CR and the corresponding Secret exists
WHEN I kubectl -n SPACE_GUID get cfserviceinstance CF_SERVICE_INSTANCE_NAME
THEN I see that status.binding.name on the CFServiceInstance is set to the name of the Secret
AND I see a BindingSecretAvailable condition in status.conditions indicating that the secret is available

status:
  binding:
    name: service-instance-secret-name
  conditions:
  - type:   BindingSecretAvailable
    status: 'True'
    reason: 'SecretFound'
    message: ''
    lastTransitionTime: '2021-01-20T17:00:00Z'

Secret Does Not Exist

GIVEN I have applied a CFServiceInstance CR that has status.binding.name set on it
WHEN I delete the referenced Secret
THEN I see that status.binding.name on the CFServiceInstance is removed
AND I see a BindingSecretAvailable condition in status.conditions indicating that the secret does not exist

status:
  binding:
    name: ""
  conditions:
  - type:   BindingSecretAvailable
    status: 'False'
    reason: 'SecretNotFound'
    message: 'Binding secret does not exist'
    lastTransitionTime: '2021-01-20T17:00:00Z'

CFServiceBinding

Secret Exists

GIVEN I have applied a CFServiceBinding CR and the corresponding Secret exists
WHEN I kubectl -n SPACE_GUID get cfservicebinding CF_SERVICE_BINDING_NAME
THEN I see that status.binding.name on the CFServiceBinding is set to the name of the Secret
AND I see a BindingSecretAvailable condition in status.conditions indicating that the secret is available

status:
  binding:
    name: service-instance-secret-name
  conditions:
  - type:   BindingSecretAvailable
    status: 'True'
    reason: 'SecretFound'
    message: ''
    lastTransitionTime: '2021-01-20T17:00:00Z'

Secret Does Not Exist

GIVEN I have applied a CFServiceBinding CR that has status.binding.name set on it
WHEN I delete the referenced Secret
THEN I see that status.binding.name on the CFServiceBinding is removed
AND I see a BindingSecretAvailable condition in status.conditions indicating that the secret does not exist

status:
  binding:
    name: ""
  conditions:
  - type:   BindingSecretAvailable
    status: 'False'
    reason: 'SecretNotFound'
    message: 'Binding secret does not exist'
    lastTransitionTime: '2021-01-20T17:00:00Z'

---

Dev Notes

• User-provided Service Instance proposal
• K8 Service Binding Spec docs for ProvisionedService duck type
• Slack thread regarding what the behavior should be if the secret doesn't exist/is deleted: https://kubernetes.slack.com/archives/C012F2GPMTQ/p1643064895006600
• We should make sure to handle eventual consistency for the case where the secret didn't exist when the reconcile loop was running; either watch secrets or requeue.

[tcdowney]

Closing: This was completed by PRs #631 and #628 and passed acceptance.