update CFServiceInstance and CFServiceBinding #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewalter
approved these changes
Feb 8, 2022
julian-hj
force-pushed
the
issues/549
branch
3 times, most recently
from
fc4a1ce
to
ca42c61
Compare
- implement the ProvisionedService duck type - manage binding secret status in Reconcile loop Co-authored-by: Andrew Costa <[email protected]> Co-authored-by: Akira Wong <[email protected]> Co-authored-by: Dave Walter <[email protected]> Co-authored-by: Julian Hjortshoj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#549
What is this change about?
Update CFServiceInstance and CFServiceBinding to implement the ProvisionedService duck type
Does this PR introduce a breaking change?
no
Acceptance Steps
See #549
Tag your pair, your PM, and/or team
@davewalter @acosta11 @gnovv