fix: Small Fixes (#1089)

cloudquery · Jun 27, 2022 · f6fec91 · f6fec91
1 parent 8f378e9
commit f6fec91
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/docs/index.md b/docs/index.md
@@ -256,15 +256,15 @@ provider "aws" {
     // Optional. if you want to assume role to multiple account and fetch data from them
     accounts "<AccountID_Alias_2>" {
       // Optional. Role ARN we want to assume when accessing this account
-      role_arn = <YOUR_ROLE_ARN_1>
+      role_arn = "<YOUR_ROLE_ARN_1>"
       // Optional. Local Profile is the named profile in your shared configuration file (usually `~/.aws/config`) that you want to use for this specific account
-      local_profile = "<NAMED_PROFILE>
+      local_profile = "<NAMED_PROFILE>"
       // Optional. Specify the Role Session name
       role_session_name = ""
     }
     accounts "<AccountID_Alias_2>" {
       // Optional. Role ARN we want to assume when accessing this account
-      role_arn = <YOUR_ROLE_ARN_2>
+      role_arn = "<YOUR_ROLE_ARN_2>"
     }
   }
 

diff --git a/resources/services/s3/buckets.go b/resources/services/s3/buckets.go
@@ -531,6 +531,9 @@ func resolveS3BucketsAttributes(ctx context.Context, meta schema.ClientMeta, res
 
 	output, err := mgr.GetBucketRegion(ctx, *resource.Name)
 	if err != nil {
+		if c.IsNotFoundError(err) {
+			return nil
+		}
 		return diag.WrapError(err)
 	}
 	// This is a weird corner case by AWS API https://github.com/aws/aws-sdk-net/issues/323#issuecomment-196584538