Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Small Fixes #1089

Merged
merged 8 commits into from
Jun 27, 2022
Merged

fix: Small Fixes #1089

merged 8 commits into from
Jun 27, 2022

Conversation

bbernays
Copy link
Contributor

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

  • Fix small s3 bug where bucket is deleted between list and GetBucketRegion
  • Fix documentation for code highlighting

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner June 21, 2022 20:27
@bbernays bbernays requested review from spangenberg and yevgenypats and removed request for a team June 21, 2022 20:27
roneli
roneli reviewed Jun 22, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a single nit

@bbernays bbernays added this to the Sprint-04-10-2022 milestone Jun 22, 2022
yevgenypats
yevgenypats approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we already convert to yaml?

@bbernays
Copy link
Contributor Author

Shouldn't we already convert to yaml?

I had opened this PR, before the Yaml merge had occurred

@bbernays bbernays merged commit f6fec91 into cloudquery:main Jun 27, 2022
@cq-bot cq-bot mentioned this pull request Jun 27, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli left review comments

@yevgenypats yevgenypats yevgenypats approved these changes

@spangenberg spangenberg Awaiting requested review from spangenberg spangenberg is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint-04-10-2022
Development

Successfully merging this pull request may close these issues.
3 participants
@bbernays @yevgenypats @roneli