This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2022
disq
force-pushed
the
feat/all-migrations-as-files
branch
from
January 14, 2022 11:27
099fbfc
to
4d1f63d
Compare
roneli
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would add a migration tester in SDK for provider to use to test its migrations
disq
force-pushed
the
feat/all-migrations-as-files
branch
2 times, most recently
from
January 17, 2022 18:41
29a2c47
to
ce67a7c
Compare
Generated with: go run tools/migrations/main.go -prefix 20_v0.10.0. -full
disq
force-pushed
the
feat/all-migrations-as-files
branch
from
January 19, 2022 10:55
055faaa
to
4eb2f8e
Compare
This was referenced Jan 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new version
4
proto and SDK.Old migrations are no more. 🦜
Version is assumed to be
v0.10.0
, migrations version15
. Migration has been generated with:To create a potential "upgrade" migration one needs to run:
and check/edit the generated
unreleased_*.sql
files accordingly.Please see relevant PRs on other projects:
cloudquery/cq-provider-sdk#146
cloudquery/cloudquery#406
https://github.com/cloudquery/docs/pull/75
https://github.com/cloudquery/cq-provider-template/pull/12