Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Testable Migrations (AWS) #401

Merged
merged 28 commits into from
Jan 20, 2022
Merged

feat: Testable Migrations (AWS) #401

merged 28 commits into from
Jan 20, 2022

Conversation

disq
Copy link
Member

@disq disq commented Jan 10, 2022

Using the new version 4 proto and SDK.
Old migrations are no more. 🦜
Version is assumed to be v0.10.0, migrations version 15. Migration has been generated with:

go run tools/migrations/main.go -prefix 15_v0.10.0 -full 

To create a potential "upgrade" migration one needs to run:

go run tools/migrations/main.go -dsn 'THE-DSN'

and check/edit the generated unreleased_*.sql files accordingly.

Please see relevant PRs on other projects:
cloudquery/cq-provider-sdk#146
cloudquery/cloudquery#406
https://github.com/cloudquery/docs/pull/75
https://github.com/cloudquery/cq-provider-template/pull/12

@disq disq requested a review from roneli January 10, 2022 23:46
@disq disq changed the title Testable Migrations Testable Migrations (AWS) Jan 11, 2022
@disq disq changed the title Testable Migrations (AWS) feat: Testable Migrations (AWS) Jan 11, 2022
@disq disq marked this pull request as ready for review January 14, 2022 11:23
@disq disq force-pushed the feat/all-migrations-as-files branch from 099fbfc to 4d1f63d Compare January 14, 2022 11:27
@github-actions github-actions bot added feature and removed feature labels Jan 16, 2022
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would add a migration tester in SDK for provider to use to test its migrations

resources/provider/migrations/postgres/20_v0.11.0.down.sql Outdated Show resolved Hide resolved
@disq disq force-pushed the feat/all-migrations-as-files branch 2 times, most recently from 29a2c47 to ce67a7c Compare January 17, 2022 18:41
@disq disq force-pushed the feat/all-migrations-as-files branch from 055faaa to 4eb2f8e Compare January 19, 2022 10:55
@github-actions github-actions bot added feat and removed feat labels Jan 20, 2022
@roneli roneli merged commit 05a0d8e into main Jan 20, 2022
@roneli roneli deleted the feat/all-migrations-as-files branch January 20, 2022 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants