This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
feat: Testable Migrations (SDK) #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roneli
suggested changes
Jan 16, 2022
provider/schema/execution.go
Outdated
Comment on lines
29
to
43
| type Database interface { | ||
| QueryExecer | ||
|
|
||
| Insert(ctx context.Context, t *Table, instance Resources) error | ||
| Delete(ctx context.Context, t *Table, kvFilters []interface{}) error | ||
| RemoveStaleData(ctx context.Context, t *Table, executionStart time.Time, kvFilters []interface{}) error | ||
| CopyFrom(ctx context.Context, resources Resources, shouldCascade bool, CascadeDeleteFilters map[string]interface{}) error | ||
| Close() | ||
| Dialect() Dialect | ||
| } | ||
|
|
||
| type QueryExecer interface { | ||
| Exec(ctx context.Context, query string, args ...interface{}) error | ||
| Query(ctx context.Context, query string, args ...interface{}) (pgx.Rows, error) | ||
| } |
There was a problem hiding this comment.
I agree, I think my comments confused a little bit. Would move QueryExecer -> database package (as like you said core packages use it and its a database thing). The Database interface is only used by execution as its an execution thing, and then I would rename it perhaps.
roneli
suggested changes
Jan 17, 2022
This was referenced Jan 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving migrations only to go-migrate, providing tools to generate SQLs (full and incremental) from
schema.TableMoving protocol version to
4Please see relevant PRs on other projects:
cloudquery/cq-provider-aws#401
cloudquery/cloudquery#406
https://github.com/cloudquery/docs/pull/75
https://github.com/cloudquery/cq-provider-template/pull/12